ef.js

Declarative DOM helper experiment

  1. 1
  2. 2
  3. 3
  4. 4
  5. 5
  6. 6
  7. 7
  8. 8
  9. 9
  10. 10
  11. 11
  12. 12
  13. 13
  14. 14
  15. 15
  16. 16
  17. 17
  18. 18
  19. 19
  20. 20
  21. 21
  22. 22
  23. 23
  24. 24
  25. 25
  26. 26
  27. 27
  28. 28
  29. 29
  30. 30
  31. 31
  32. 32
  33. 33
  34. 34
  35. 35
  36. 36
  37. 37
  38. 38
  39. 39
  40. 40
  41. 41
  42. 42
  43. 43
  44. 44
  45. 45
  46. 46
  47. 47
  48. 48
  49. 49
  50. 50
  51. 51
  52. 52
  53. 53
  54. 54
  55. 55
  56. 56
  57. 57
  58. 58
  59. 59
  60. 60
  61. 61
  62. 62
  63. 63
  64. 64
  65. 65
  66. 66
  67. 67
  68. 68
  69. 69
  70. 70
  71. 71
  72. 72
  73. 73
  74. 74
  75. 75
  76. 76
  77. 77
  78. 78
  79. 79
  80. 80
  81. 81
  82. 82
  83. 83
  84. 84
  85. 85
  86. 86
  87. 87
  88. 88
  89. 89
  90. 90
  91. 91
  92. 92
  93. 93
  94. 94
  95. 95
  96. 96
  97. 97
  98. 98
  99. 99
  100. 100
  101. 101
  102. 102
  103. 103
  104. 104
  105. 105
  106. 106
  107. 107
  108. 108
  109. 109
  110. 110
  111. 111
  112. 112
  113. 113
  114. 114
  115. 115
  116. 116
  117. 117
  118. 118
  119. 119
  120. 120
  121. 121
  122. 122
  123. 123
  124. 124
  125. 125
  126. 126
  127. 127
  128. 128
  129. 129
  130. 130
  131. 131
  132. 132
  133. 133
  134. 134
  135. 135
  136. 136
  137. 137
  138. 138
  139. 139
  140. 140
  141. 141
  142. 142
  143. 143
  144. 144
  145. 145
  146. 146
  147. 147
  148. 148
  149. 149
  150. 150
  151. 151
  152. 152
  153. 153
  154. 154
  155. 155
  156. 156
  157. 157
  158. 158
  159. 159
  160. 160
  161. 161
  162. 162
  163. 163
  164. 164
  165. 165
  166. 166
  167. 167
  168. 168
  169. 169
  170. 170
  171. 171
  172. 172
  173. 173
  174. 174
  175. 175
// This script checks `import`s in TypeScript files under `src/` have ".js"
// file extension in its import path. In Node.js ESM, import path must have
// a file extension, while TypeScript has been using extension-less import
// even with Node.js ESM module setting. That means, runtime error happens
// when importing an ESM module TypeScript deliberately emitted.
//
// (OK) import "./foo.js";
// (NG) import "./foo";     ... Runtime error, both in Node.js and basic file server.
// (NG) import "./foo.ts";  ... ".ts" remains in emitted JS files.
// (NG) require("./foo");   ... Enough.
// (NG) import("./foo.js"); ... This package should be minimal set of functions.

import { file, Transpiler } from "bun";
import chalk from "chalk";
import { readdirSync } from "node:fs";
import { relative } from "node:path";

export enum RuleViolationKind {
  ExtensionLessImport,
  CJS,
  DynamicImport,
}

export interface ImportRuleViolation {
  kind: RuleViolationKind;

  importPath: string;
}

export interface OffendingFile {
  url: URL;

  violations: readonly ImportRuleViolation[];
}

export interface CheckResult {
  checkedFiles: number;

  offendingFiles: readonly OffendingFile[];
}

async function checkFile(
  t: Transpiler,
  url: URL,
): Promise<readonly ImportRuleViolation[]> {
  const contents = await file(url).arrayBuffer();

  const imports = t.scanImports(contents);

  return imports
    .map<ImportRuleViolation | null>((i) => {
      switch (i.kind) {
        case "dynamic-import":
          return {
            kind: RuleViolationKind.DynamicImport,
            importPath: i.path,
          };
        case "require-call":
        case "require-resolve":
          return {
            kind: RuleViolationKind.CJS,
            importPath: i.path,
          };
        case "import-statement": {
          if (!i.path.endsWith(".js")) {
            return {
              kind: RuleViolationKind.ExtensionLessImport,
              importPath: i.path,
            };
          }

          return null;
        }
        default: {
          return null;
        }
      }
    })
    .filter((v): v is ImportRuleViolation => v !== null);
}

async function checkDir(t: Transpiler, dir: URL): Promise<CheckResult> {
  let checkedFiles = 0;
  const offendingFiles: OffendingFile[] = [];

  for (const entry of readdirSync(dir, { withFileTypes: true })) {
    if (entry.isDirectory()) {
      const result = await checkDir(t, new URL(entry.name + "/", dir));

      checkedFiles += result.checkedFiles;
      offendingFiles.push(...result.offendingFiles);
      continue;
    }

    if (!entry.isFile() || !entry.name.endsWith(".ts")) {
      continue;
    }

    checkedFiles += 1;

    const fileUrl = new URL(entry.name, dir);

    const violations = await checkFile(t, fileUrl);
    if (violations.length === 0) {
      continue;
    }

    offendingFiles.push({
      url: fileUrl,
      violations,
    });
  }

  return {
    checkedFiles,
    offendingFiles,
  };
}

export async function checkImports(srcDir: URL): Promise<CheckResult> {
  const transpiler = new Transpiler({
    loader: "ts",
  });

  return checkDir(transpiler, srcDir);
}

function kindToLabel(kind: RuleViolationKind): string {
  switch (kind) {
    case RuleViolationKind.CJS:
      return "CommonJS import is not allowed.";
    case RuleViolationKind.DynamicImport:
      return "Dynamic import is not allowed.";
    case RuleViolationKind.ExtensionLessImport:
      return `Import path must end with ".js".`;
  }
}

if (import.meta.main) {
  const result = await checkImports(new URL("../src/", import.meta.url));

  console.error(
    chalk.white(`Checked ${chalk.bold("%s")} files.`),
    result.checkedFiles,
  );

  if (result.offendingFiles.length === 0) {
    console.error(chalk.white("No import rule violations found."));
    process.exit(0);
  }

  console.error(
    chalk.red("%s have import rule violations."),
    result.offendingFiles.length > 1
      ? result.offendingFiles.length + " files"
      : "1 file",
  );

  for (const file of result.offendingFiles) {
    console.error(
      chalk.white(`[%s]`),
      relative(process.cwd(), file.url.pathname),
    );

    for (const violation of file.violations) {
      console.error(
        chalk.white(` %s: %s`),
        chalk.yellow(`"${violation.importPath}"`),
        chalk.red(kindToLabel(violation.kind)),
      );
    }
  }

  process.exit(1);
}