Fix weird URL search parameter handling (raw=true) A query component in URL does not have to be "key=value". In fact, browsers interpret that as a URLSearchParams, a list of "key" or "key=value" allowing a same key appearing multiple times. You don't have to set "true" or "false": simply set the key or remove the one.

Changes

3 changed files (+4/-8)

• routes/preview/renderer.go
  • @@ -45,7 +45,7 @@ func (r MarkdownToHtmlRenderer) Render(code []byte) ([]byte, error) {
    } queries := parsedURL.Query() - queries.Add("raw", "1") + queries.Add("raw", "") parsedURL.RawQuery = queries.Encode() node.LinkData.Destination = []byte(parsedURL.String())
• routes/routes.go
  • @@ -11,7 +11,6 @@ import (
    "os" "path/filepath" "sort" - "strconv" "strings" securejoin "github.com/cyphar/filepath-securejoin"
  • @@ -156,7 +155,7 @@ func (d *deps) RepoIndex(w http.ResponseWriter, r *http.Request) {
    } if node.Type == blackfriday.Image { - node.LinkData.Destination = fmt.Appendf([]byte{}, "/%s/blob/%s/%s?raw=true", name, mainBranch, href) + node.LinkData.Destination = fmt.Appendf([]byte{}, "/%s/blob/%s/%s?raw", name, mainBranch, href) } else if strings.LastIndexByte(href, '/') == len(href)-1 { node.LinkData.Destination = fmt.Appendf([]byte{}, "/%s/tree/%s/%s", name, mainBranch, href) node.LinkData.Destination = node.LinkData.Destination[:len(node.LinkData.Destination)-1]
  • @@ -284,10 +283,7 @@ func (d *deps) RepoTree(w http.ResponseWriter, r *http.Request) {
    } func (d *deps) FileContent(w http.ResponseWriter, r *http.Request) { - var raw bool - if rawParam, err := strconv.ParseBool(r.URL.Query().Get("raw")); err == nil { - raw = rawParam - } + raw := r.URL.Query().Has("raw") name := r.PathValue("name") if d.isIgnored(name) {
• templates/repo-blob-ref.html.tmpl
  • @@ -75,7 +75,7 @@ SPDX-License-Identifier: MIT
    {{- template "tab-selector" -}} <dt class="metadata--key">Raw</dt> <dd class="metadata--value"> - <a href="?raw=true">View raw</a> + <a href="?raw">View raw</a> </dd> {{- range .PreviewTypes -}} <dt class="metadata--key">Preview (<span class="preview-type">{{ . }}</span>)</dt>