Redirect to URL without trailing slash The new router does not care trailing slash. However it's better to canonicalize to one with trailing slash or without the one for indexing, caching, and other various reasons. The change to test file is net/http.Get being "smart" and clean Location header so it'll be resolved to "/foo" on client side (= test code).

Changes

2 changed files (+8/-1)

• pages/escaping_test.go
  • @@ -131,7 +131,7 @@ func TestRepoTreePreventsPathTraversal(t *testing.T) {
    server := httptest.NewServer(New(core)) defer server.Close() - for _, p := range []string{"/../", "/.././../"} { + for _, p := range []string{"/../", "/.././.."} { target, err := url.JoinPath(server.URL, "/foo/tree/trunk") if err != nil { t.Fatal(err)
• pages/pages.go
  • @@ -36,6 +36,13 @@ func (pages *Pages) ServeHTTP(w http.ResponseWriter, r *http.Request) {
    return } + if strings.HasSuffix(r.URL.Path, "/") { + r.URL.Path = strings.TrimRight(r.URL.Path, "/") + w.Header().Add("Location", r.URL.String()) + w.WriteHeader(http.StatusPermanentRedirect) + return + } + // "/static/<path>*" if strings.Index(r.URL.Path, staticPrefix) == 0 { http.ServeFileFS(w, r, pages.core.StaticDir, strings.TrimPrefix(r.URL.Path, staticPrefix))