Remove `FileSystemReader.readFile` Less API surface, more consolidated API is better.

Changes

4 changed files (+5/-24)

• filesystem_reader/deno_fs.ts
  • @@ -154,8 +154,4 @@ };
    return root; } - - async readFile(path: readonly string[]): Promise<Uint8Array> { - return await Deno.readFile(this.#resolve(path)); - } }
• filesystem_reader/interface.ts
  • @@ -9,12 +9,4 @@ /**
    * Returns the topmost directory this FileSystem Reader can operate on. */ getRootDirectory(): Promise<RootDirectoryReader>; - - /** - * Directly read file contents at given path. - * Throws if path does not exist or found directory. - * You should traverse from `getRootDirectory()` for most cases. - * @deprecated Use `RootDirectoryReader.openFile` then `FileReader.read` instead. - */ - readFile(path: readonly string[]): Promise<Uint8Array>; }
• filesystem_reader/memory_fs.ts
  • @@ -186,13 +186,4 @@ };
    return Promise.resolve(root); } - - async readFile(path: readonly string[]): Promise<Uint8Array> { - const file = await this.#getAtRecur(path, await this.getRootDirectory()); - if (file.type === "directory") { - throw new Error(`MemoryFsReader: ${path.join(SEP)} is directory`); - } - - return file.read(); - } }
• page_builder/default_theme/builder.tsx
  • @@ -115,11 +115,13 @@ assets.globalCss,
    new TextEncoder().encode(styles), ); + const root = await fileSystemReader.getRootDirectory(); + if (this.#faviconSvg) { assets.faviconSvg = this.#faviconSvg; await fileSystemWriter.write( assets.faviconSvg, - await (fileSystemReader.readFile(this.#faviconSvg)), + await (await root.openFile(this.#faviconSvg)).read(), ); }
  • @@ -127,7 +129,7 @@ if (this.#faviconPng) {
    assets.faviconPng = this.#faviconPng; await fileSystemWriter.write( assets.faviconPng, - await (fileSystemReader.readFile(this.#faviconPng)), + await (await root.openFile(this.#faviconPng)).read(), ); }
  • @@ -135,7 +137,7 @@ if (this.#siteLogo) {
    assets.siteLogo = this.#siteLogo; await fileSystemWriter.write( assets.siteLogo, - await (fileSystemReader.readFile(this.#siteLogo)), + await (await root.openFile(this.#siteLogo)).read(), ); }