Commits at 8526d465efc5215b45425e756c8a85afefdd37eb
8526d465Style anchors using class selector, rather than type selector
Type selector, which selects all tags/elements that matches,
often causes unexpected side-effect. For example, if an internal
component includes anchor element, the default style for contents
also applys to the internal anchor, which is not desirable.
Shota FUJI
authored at
Shota FUJI
comitted at
bd077317Style syntax highlighted code block
This patch also removes annoying semi-global style for main contents.
Shota FUJI
authored at
Shota FUJI
comitted at
94b55a12Use hastscript instead of nano_jsx
The first reason for this change is tedious conversion from Markdown to components.
Since Hast does not have a concept of "Component", those needs to be converted to
custom elements first, then restored by carefully mapping the custom element nodes.
During that process, properties are transformed to HTML attributes (e.g. true -> "").
This is very error-prone and exhausting thing to write.
The second one is the quality of nano-jsx. The library is, honestly, toy-level.
Even though they promote it as "SSR First", HTML seriealization is joke: empty children
appears as `children=""`, cannot handle falsy attribute values, renders `true` attribute
value as `"true"`, etc...
Also, it's TypeScript typing is almost non-existent. Most of the exposed things are
typed as `any`. I would not call that a typed library.
While hastscript is not perfect either, it's good enough for my HTML generation usecase.
It also eliminates Mdast -> Hast -> (JSX runtime) confusing data conversion.
I choose not to write wrapper for `<Component/>` usage. It's nice, but not necessary.
In fact, normal function call is **far better** than JSX's loose and cryptic typings.
The only output changes I observed was "Module" and "Program" in "Architecture.canvas"
now overflows (thus broken in Safari). However, it's due to the new more strict CSS.
I believe it's improvement, not regression (needs to be fixed the overall JSONCanvas
stylings at some point, though).
Shota FUJI
authored at
Shota FUJI
comitted at
e635bd88Style GFM task list extension's output
The default output, which mimics GitHub's markup and styles, is horrible.
It sets `disabled` attribute that makes the element screen reader unfriendly.
Also it does not associate the text to checkbox, which is also screen reader unfriendly.
I may revisit styles in the future as the current one is not that pretty...
Shota FUJI
authored at
Shota FUJI
comitted at
49403feeFix content style having higher priority than component styles
I noticed this by seeing non-foldable callout's title being weirdly wrapped.
Shota FUJI
authored at
Shota FUJI
comitted at
9ee3d742Limit content styles only to body elements
Global styles have been a pain point.
Shota FUJI
authored at
Shota FUJI
comitted at
110d8d4eMove Hast related function inside page builder to one place
I have been felt those logics are disconnected.
Shota FUJI
authored at
Shota FUJI
comitted at
9626d6f3Fix Canvas having no color other than red and gray
Simple typo.
Shota FUJI
authored at
Shota FUJI
comitted at
d14df0a6Proper styles for callout
This work is foundation for later styling works.
Shota FUJI
authored at
Shota FUJI
comitted at
5aad74eaFix callout icon is not visible
hast-util-raw seems to lowercases every tagnames.
Shota FUJI
authored at
Shota FUJI
comitted at
432427c4Fix default opened callout is collapsed
hast-util-raw seems to have a bug on attribute handling: it mistake
an empty string as an absence of value.
Shota FUJI
authored at
Shota FUJI
comitted at
eac79b36Do not perform actual file write more than once on same file
Shota FUJI
authored at
Shota FUJI
comitted at
a9bf5e66File embed for JSONCanvas
Refactor for HTML rendering is to reduce unnecessary Mdast->Hast conversion.
Shota FUJI
authored at
Shota FUJI
comitted at