gtk-adwaita: Seek feature GTK4's slider/range widget is shitty, thus this feature works shitty as well. There are no "drag ended" equivalent signal and drag start emits JUMP scroll type value change signal. Also, setting `false` to `sensitive` resets focus so long jump using keyboard is impossible too. Debouncing or throttling would help a little bit, but won't solve the problem fundamentally. Seek change events sent by server would resets drag operation. Valadoc shows no result for "throttle/debounce" and GTK4 seems to have no function and widget for that. Implementing debounce/throttle function by hand, testing that, and adding additional delay to seek triggered by seek is not acceptable given those won't work when a track is playing. The only way to solve this is implementing custom widget, which means re-implementing slider UI from scratch or carefully patching and workarounding GtkRange's internal implementation. Both are time-consuming, exhausting, negatively effects maintainability, and stupid. GTK4's rendered widget is great. Its API and abstraction are dogshit.

Changes

2 changed files (+31/-0)

• gtk-adwaita/src/Plac.vala
  • @@ -160,6 +160,19 @@
    yield; } + public async Transport.SeekResultCode seek(Transport.Zone zone, int64 at_seconds) { + GLib.SourceFunc callback = seek.callback; + Transport.SeekResultCode code = UNKNOWN_ERROR; + + new GLib.Thread<void>("seek", () => { + code = conn.seek(zone, at_seconds); + GLib.Idle.add((owned) callback); + }); + + yield; + return code; + } + public async Browse.Result? browse(Browse.Hierarchy hierarchy, Transport.Zone? zone, Browse.Item? item, bool back) { GLib.SourceFunc callback = browse.callback; Browse.Result? result = null;
• gtk-adwaita/src/Widgets/PlaybackToolbar.vala
  • @@ -145,6 +145,24 @@ this.enable_actions();
    }); }); + seek.change_value.connect((scroll, value) => { + var row = zone_rows[zone_id]; + if (row == null) { + return true; + } + + this.disable_actions(); + conn.seek.begin(row.zone, (int64) value, (obj, res) => { + var result = conn.seek.end(res); + if (result != OK) { + GLib.log("Plac", LEVEL_WARNING, "Failed to seek: %s", result.to_string()); + } + + this.enable_actions(); + }); + return true; + }); + conn.zones_changed.connect((event) => { foreach (string id in event.removed) { GLib.log("Plac", LEVEL_DEBUG, "Zone id=%s removed", id);