gtk-adwaita: Disable playback control during request To prevent excess requests and such.

Changes

3 changed files (+45/-7)

• gtk-adwaita/data/ui/playback-toolbar.ui
  • @@ -84,7 +84,7 @@ <property name="margin-start">3</property>
    <property name="margin-end">12</property> <property name="spacing">8</property> <child> - <object class="GtkBox"> + <object class="GtkBox" id="controls"> <property name="orientation">horizontal</property> <property name="spacing">2</property> <child>
• gtk-adwaita/src/Plac.vala
  • @@ -136,8 +136,15 @@ return false;
    }); } - public void control(Transport.Zone zone, uint16 action) { - conn.control(zone, action); + public async void control(Transport.Zone zone, uint16 action) { + GLib.SourceFunc callback = control.callback; + + new GLib.Thread<void>("control", () => { + conn.control(zone, action); + GLib.Idle.add((owned) callback); + }); + + yield; } public async Browse.Result? browse(Browse.Hierarchy hierarchy, Transport.Zone? zone, Browse.Item? item, bool back) {
• gtk-adwaita/src/Widgets/PlaybackToolbar.vala
  • @@ -20,6 +20,9 @@ class PlaybackToolbar : Gtk.Box {
    public signal void zone_selected(Plac.Transport.Zone? zone); [GtkChild] + private unowned Gtk.Box controls; + + [GtkChild] private unowned Gtk.Button play; [GtkChild]
  • @@ -91,7 +94,11 @@ if (row == null) {
    return; } - conn.control(row.zone, Plac.Transport.ACTION_PLAY); + this.disable_actions(); + conn.control.begin(row.zone, Plac.Transport.ACTION_PLAY, (obj, res) => { + conn.control.end(res); + this.enable_actions(); + }); }); pause.clicked.connect(() => {
  • @@ -100,7 +107,11 @@ if (row == null) {
    return; } - conn.control(row.zone, Plac.Transport.ACTION_PAUSE); + this.disable_actions(); + conn.control.begin(row.zone, Plac.Transport.ACTION_PAUSE, (obj, res) => { + conn.control.end(res); + this.enable_actions(); + }); }); prev.clicked.connect(() => {
  • @@ -109,7 +120,11 @@ if (row == null) {
    return; } - conn.control(row.zone, Plac.Transport.ACTION_PREV); + this.disable_actions(); + conn.control.begin(row.zone, Plac.Transport.ACTION_PREV, (obj, res) => { + conn.control.end(res); + this.enable_actions(); + }); }); next.clicked.connect(() => {
  • @@ -118,7 +133,11 @@ if (row == null) {
    return; } - conn.control(row.zone, Plac.Transport.ACTION_NEXT); + this.disable_actions(); + conn.control.begin(row.zone, Plac.Transport.ACTION_NEXT, (obj, res) => { + conn.control.end(res); + this.enable_actions(); + }); }); conn.zones_changed.connect((event) => {
  • @@ -239,6 +258,18 @@ play.visible = false;
    pause.visible = true; break; } + } + + private void disable_actions() { + zone_list_popover.sensitive = false; + controls.sensitive = false; + seek.sensitive = false; + } + + private void enable_actions() { + zone_list_popover.sensitive = true; + controls.sensitive = true; + seek.sensitive = true; } }