Fix seekbar behavior being flaky Sometimes the seekbar remains disabled (`sensitive = false`) and sometime it keeps previous tracks seek location after track changed. These are due to mishandling of `seek_position`'s nullability.

Changes

1 changed files (+7/-7)

• src/Widgets/PlaybackToolbar.vala
  • @@ -290,7 +290,8 @@ if (selected_zone == null || selected_zone.zone_id != change.zone_id) {
    return; } - if (seek.sensitive) { + if (selected_zone.now_playing != null && selected_zone.now_playing.length > 0) { + seek.sensitive = true; seek.set_value(change.seek_position); seek.tooltip_text = format_seconds(change.seek_position); }
  • @@ -322,14 +323,13 @@ playing_line2.label = "";
    artwork.image_key = null; } - if ( - zone.now_playing != null && - zone.now_playing.has_seek_position - ) { + if (zone.now_playing != null) { seek.sensitive = true; seek.set_range(0, zone.now_playing.length); - seek.set_value(zone.now_playing.seek_position); - seek.tooltip_text = format_seconds(zone.now_playing.seek_position); + if (zone.now_playing.has_seek_position) { + seek.set_value(zone.now_playing.seek_position); + seek.tooltip_text = format_seconds(zone.now_playing.seek_position); + } } else { seek.sensitive = false; seek.set_range(0, 1);