core: Fix memory leaks

Changes

2 changed files (+15/-6)

• core/src/roon/services/registry.zig
  • @@ -48,11 +48,14 @@ var fbs = std.io.fixedBufferStream(request);
    try moo.encode(fbs.writer(), meta, header, body); const message = try conn.request(request_id, request); - errdefer conn.allocator.free(message); + defer conn.allocator.free(message); _, const header_ctx = try moo.Metadata.parse(message); _, const body_ctx = try moo.WellKnownHeaders.parse(message, header_ctx); - return try moo.JsonBody(InfoResponse).parse(allocator, message, body_ctx, .{ .ignore_unknown_fields = true }); + return try moo.JsonBody(InfoResponse).parse(allocator, message, body_ctx, .{ + .ignore_unknown_fields = true, + .allocate = .alloc_always, + }); } pub const RegisterResponse = struct {
  • @@ -82,7 +85,7 @@ var fbs = std.io.fixedBufferStream(request);
    try moo.encode(fbs.writer(), meta, header, body); const message = try conn.request(request_id, request); - errdefer conn.allocator.free(message); + defer conn.allocator.free(message); const meta_res, const header_ctx = try moo.Metadata.parse(message); if (!std.mem.eql(u8, meta_res.service, "Registered")) {
  • @@ -91,6 +94,9 @@ return RegisterError.NonSuccessResponse;
    } _, const body_ctx = try moo.WellKnownHeaders.parse(message, header_ctx); - return try moo.JsonBody(RegisterResponse).parse(allocator, message, body_ctx, .{ .ignore_unknown_fields = true }); + return try moo.JsonBody(RegisterResponse).parse(allocator, message, body_ctx, .{ + .ignore_unknown_fields = true, + .allocate = .alloc_always, + }); } };
• core/src/roon/services/transport.zig
  • @@ -82,7 +82,7 @@ var fbs = std.io.fixedBufferStream(request);
    try moo.encode(fbs.writer(), meta, headers, body); const message = try conn.request(request_id, request); - errdefer conn.allocator.free(message); + defer conn.allocator.free(message); const meta_res, const header_ctx = try moo.Metadata.parse(message); if (!std.mem.eql(u8, meta_res.service, "Success")) {
  • @@ -93,6 +93,9 @@
    const headers_res, const body_ctx = try moo.WellKnownHeaders.parse(message, header_ctx); std.log.debug("Got successful response on {s}/get_zones (request_id={d})", .{ id, headers_res.request_id }); - return try moo.JsonBody(GetZonesResponse).parse(allocator, message, body_ctx, .{ .ignore_unknown_fields = true }); + return try moo.JsonBody(GetZonesResponse).parse(allocator, message, body_ctx, .{ + .ignore_unknown_fields = true, + .allocate = .alloc_always, + }); } };