1. Top
  2. plac
  3. Commits
plac

Roon remote in GTK4

Commits at 1a6e7d04dae8ecffd4ae34b16f99334a42bf314f

  1. 0d19d03e Fix debug log not describing what the number is Shota FUJI authored at Shota FUJI comitted at
  2. d1962e17 Fix seekbar behavior being flaky Sometimes the seekbar remains disabled (`sensitive = false`) and sometime it keeps previous tracks seek location after track changed. These are due to mishandling of `seek_position`'s nullability. Shota FUJI authored at Shota FUJI comitted at
  3. 61dd1427 Use Zone class directly for view model `Zone` class became GObject. Shota FUJI authored at Shota FUJI comitted at
  4. 28bbf5cf Use json-glib instead of Zig module To integrate to GLib ecosystem more. I rejected json-glib before due to poor API, but the lure of "Vala only codebase" was too attractive. While the new codebase is quite verbose, overall line counts are lower than the before. Due to C API deserializing and serializing code is not readable and error-prone. I created `JsonHelper` module to mitigate the shitty API but it's nowhere near perfect. These code seriously need unit tests, but that would take a while. For now, this is good enough. Shota FUJI authored at Shota FUJI comitted at
  5. 1550d119 Remove unused dependencies (Zig packages) Shota FUJI authored at Shota FUJI comitted at
  6. 7ad3f9fe Put space after type parameter's close angle It was so ugly and stupid but I had no idea which uncrustify property is the culprit. Shota FUJI authored at Shota FUJI comitted at
  7. 19824f68 Rename namespace "Plac.V2" to "Plac" V1 code is no longer there. Shota FUJI authored at Shota FUJI comitted at
  8. 7bd484b9 Rewrite WS connection and messaging in Vala (GLib) The added overheads, especially cognitive overhead, had been bothering me long time. Communicating via plain C FFI also means the Zig part has to take care of thread-safety *outside of* GLib main-loop, which comes with noticeable performance penalty. By implementing (almost) everything in Vala, thread unsafety and performance penalty caused by locking have gone. Browser navigations are much quicker and I'm yet to see a single unresponsed request. JSON serializing and deserializing module is the only remaining Zig code. Although I'd much like to this part to Vala as well, JSON handling in Vala is horrible shit so I doubt the migration will happen in a foreseeable future. This patch just replaces the C API (in Zig) by Vala counterpart. I did not application restructure or refactor or whatever. Those will make this patch more difficult to view. The only difference (regression?) is the connection object cannot withstand WebSocket connection closing. However, in my limited testing, libsoup seems to keep WebSocket connection even when computer is sleeping... so the chance of disconnection will be lower than before therefore that's not a huge problem. Shota FUJI authored at Shota FUJI comitted at
  9. 23e3c3b1 Fix constructor functions for seriealizer use uint8[] rather than string Shota FUJI authored at Shota FUJI comitted at
  10. 1beb90b5 Fix typo Shota FUJI authored at Shota FUJI comitted at
  11. 28086d81 Fix Browse.Load.Response leaks memory Shota FUJI authored at Shota FUJI comitted at
  12. 9783dfaa Create transport response objects Shota FUJI authored at Shota FUJI comitted at
  13. c8f2e26f Create transport request objects Shota FUJI authored at Shota FUJI comitted at
  14. 1f8846d0 JSON API for register request and response This got individual commit because the request needs additional change to API builder code. Shota FUJI authored at Shota FUJI comitted at
  15. 5e58e356 Rewrite server resolve process in Vala Shota FUJI authored at Shota FUJI comitted at
  16. 798ecc52 Create Roon request and response handle library in Zig Vala's (GTK ecosystem's) JSON parsing is dogshit. Although I'd like to write an entire codebase in Vala, this is necessary to maintain readability and quality. This commit only contains browse request/response for brevity. Shota FUJI authored at Shota FUJI comitted at
  17. 6c1c34ed Create helper class for body extracting This does not have actual JSON parsing, as parsing JSON in Vala is totally mess, nightmare. The only (?) seemingly-reliable library is json-glib. Documentation is unorganized mess as usual in GTK-related project, so it does not dismiss the value. Extremely imperative and quite verbose API is tolerable if it's used for rare case such as string-to-enum conversion. The problem is the library is not well integrated GLib ecosystem, despite it being under GLib project. It has GObject serialization and deserialization functionality, and they are bare minimum. No array support, top-level MUST be an object... Imperative API also is full of footgun, such as getting a data from node in mismatching type returns "NULL" or "0"... In addition to that, I see no mention of "null or field omit" in methods I checked. That may okay as a C library, but definetely does not meet a quality required to be used in high-level languages, Vala. Little bit cumbersome, but seriealize and deserialize in Zig via FFI is much much much cleaner and better. Considering how widespread JSON is, I can't recommend Vala as a sole application development language to anyone, especially the application involves networking. For GTK application development, Rust would be the best choice nowadays? Shota FUJI authored at Shota FUJI comitted at
  18. c0fd3c85 Create MOO headers parser in Vala Shota FUJI authored at Shota FUJI comitted at
  19. e2d16abd Create MOO metadata parser in Vala The first and primary reason is better integration to GTK ecosystem. GObject, GString (null-terminated strings,) GError, etc... Bridging Zig (or any other system language with C API export) to those are tedious and error-prone task. If the extra allocations (copy) are necessary due to the fucking null-terminated strings, why not writing the whole logic in Vala? The burden of bridges outweighs the ergonomics of using Zig with copy-every-string approach. The second reason is I wanted to see what is like to write non-GUI code in Vala, including unit testing. It turns out really bad, because of null-terminated fucking string and lack of converting it to/from length specified bytes. Shota FUJI authored at Shota FUJI comitted at
  20. 2c27fac8 Extract Vala compilation step to individual file I was trying to configure unit testing for Vala, but it was too repetitive writing same "addSystemCommand" step. This struct style is much cleaner and self-descriptiveto. Shota FUJI authored at Shota FUJI comitted at
  21. 4729483a Remove unused Zig package Shota FUJI authored at Shota FUJI comitted at
  22. f0733ed4 Extract new core classes to individual files It was really difficult to read or modify code due to lack of per-file isolation (relying on manual namespacing.) Shota FUJI authored at Shota FUJI comitted at
  23. 9dfa25f8 Remove unused file modulemap is for using C API inside Swift (Xcode?) Shota FUJI authored at Shota FUJI comitted at
  24. 52424bba Migrate server discovery to Vala For tighter integration and make the whole app GLib-y. Shota FUJI authored at Shota FUJI comitted at
  25. c5add195 Invalidate dprint cache after change to uncrustify.cfg Shota FUJI authored at Shota FUJI comitted at
  26. 65062858 Format Vala files It seems changes to "uncrustify.cfg" has not been read by dprint. Temporarily set "cacheKey" then reran, now every Vala files are formatted. Shota FUJI authored at Shota FUJI comitted at
  27. f03491b5 Indent namespace It's really hard to read. Shota FUJI authored at Shota FUJI comitted at
  28. c2207f32 Remove blank lines before close brace Shota FUJI authored at Shota FUJI comitted at
  29. 307a1081 Add required dependency to README Shota FUJI authored at Shota FUJI comitted at
  30. 07f92073 Delete image download logic from Zig core No longer used. Shota FUJI authored at Shota FUJI comitted at