Fix lat/lon accepts negative number with suffix Values like -1.2345N are illegal and confusing. As I've added "--latitude" and "--longitude" options, there are no need for supporting negative suffixed values.

Changes

1 changed files (+10/-0)

• src/RunOptions.zig
  • @@ -246,6 +246,10 @@
    const lastChar = x[x.len - 1]; const value = std.fmt.parseFloat(f64, x[0 .. x.len - 1]) catch return null; + if (value < 0) { + return null; + } + return switch (lastChar) { 'N' => value, 'S' => -value,
  • @@ -257,6 +261,7 @@ test parseSuffixedLatitude {
    try std.testing.expectEqual(29.977435, parseSuffixedLatitude("29.977435N")); try std.testing.expectEqual(-29.977435, parseSuffixedLatitude("29.977435S")); try std.testing.expectEqual(null, parseSuffixedLatitude("29.977435W")); + try std.testing.expectEqual(null, parseSuffixedLatitude("-29.977435N")); } fn parseSuffixedLongitude(x: []const u8) ?f64 {
  • @@ -267,6 +272,10 @@
    const lastChar = x[x.len - 1]; const value = std.fmt.parseFloat(f64, x[0 .. x.len - 1]) catch return null; + if (value < 0) { + return null; + } + return switch (lastChar) { 'E' => value, 'W' => -value,
  • @@ -278,6 +287,7 @@ test parseSuffixedLongitude {
    try std.testing.expectEqual(31.132484, parseSuffixedLongitude("31.132484E")); try std.testing.expectEqual(-31.132484, parseSuffixedLongitude("31.132484W")); try std.testing.expectEqual(null, parseSuffixedLongitude("31.132484N")); + try std.testing.expectEqual(null, parseSuffixedLongitude("-31.132484E")); } pub fn toC(self: *const @This()) c.runStruct {