macos: Fix cancelling extension registration not close connection Roon UI piles up "<extension name> (Enable)" rows everytime user cancels then reconnects.

Changes

2 changed files (+50/-49)

• macos/RoonKit/Sources/RoonKit/Connection/Connection.swift
  • @@ -159,22 +159,28 @@ public actor Connection: Connectable, Communicatable {
    } } - do { - logger.debug("Querying server info") - let res = try await request(Moo(info: .init()), timeout: .seconds(3)) - let info = try RegistryService.InfoResponse(res) - guard info.coreId == serverID else { - throw ConnectError.serverIDMismatch + try await withTaskCancellationHandler { + do { + logger.debug("Querying server info") + let res = try await request(Moo(info: .init()), timeout: .seconds(3)) + let info = try RegistryService.InfoResponse(res) + guard info.coreId == serverID else { + throw ConnectError.serverIDMismatch + } } - } - do { - logger.debug("Registering extension") - // This stays pending until user accepts the extension on Roon settings page. - // Because of this, setting timeout does not make sense here. - let res = try await request(Moo(register: ext)) - let result = try RegistryService.RegisterResponse(res) - token = result.token + do { + logger.debug("Registering extension") + // This stays pending until user accepts the extension on Roon settings page. + // Because of this, setting timeout does not make sense here. + let res = try await request(Moo(register: ext)) + let result = try RegistryService.RegisterResponse(res) + token = result.token + } + } onCancel: { + Task.detached { + await self.conn.forceCancel() + } } }
• macos/plac/DataModels/ConnectionDataModel.swift
  • @@ -111,42 +111,37 @@ final class ConnectionDataModel {
    self.loop = Task { [weak self] in while true { do { - let conn: Connection - let connectionStartsAt: ContinuousClock.Instant - if let self = self { - state = .connecting - - let ext = RegistryService.Extension( - id: "jp.pocka.plac.apple", - displayName: "Plac for \(systemName)", - version: "0.0.1", - publisher: "Shota FUJI", - email: "pockawoooh@gmail.com", - requiredServices: [ - TransportService.id, BrowseService.id, ImageService.id, - ], - token: token, - ) - - conn = try await Connection( - id: serverID, - host: host, - port: port, - ext: ext - ) - - state = .connected(conn) - - connectionStartsAt = ContinuousClock.now - - self.token = await conn.token - - if let token = self.token { - onConnect?(token) - } - } else { - return + self?.state = .connecting + + let ext = RegistryService.Extension( + id: "jp.pocka.plac.apple", + displayName: "Plac for \(systemName)", + version: "0.0.1", + publisher: "Shota FUJI", + email: "pockawoooh@gmail.com", + requiredServices: [ + TransportService.id, BrowseService.id, ImageService.id, + ], + token: token, + ) + + let conn = try await Connection( + id: serverID, + host: host, + port: port, + ext: ext + ) + + self?.state = .connected(conn) + + let connectionStartsAt = ContinuousClock.now + + let token = await conn.token + + self?.token = token + if let token = token { + onConnect?(token) } await conn.lifetime()