Add stop button to playback toolbar It works like the one on a cassette player. I wanted it to behave like other apps, but Roon API lacks "clear queue" functionality. It does have "subscribe to queue changes" and "play from this queue item" but using those are hacky and fragile. <https://codeberg.org/pocka/plac-for-gtk4/issues/24>

Changes

7 changed files (+54/-0)

• data/gresource.xml
  • @@ -41,6 +41,7 @@ SPDX-License-Identifier: Apache-2.0
    <file preprocess="xml-stripblanks">icons/scalable/actions/skip-backwards-10-symbolic.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/skip-forward-10-symbolic.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/skip-forward-large-symbolic.svg</file> + <file preprocess="xml-stripblanks">icons/scalable/actions/stop-large-symbolic.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/sound-symbolic.svg</file> <file preprocess="xml-stripblanks">icons/scalable/actions/view-more-symbolic.svg</file> <file preprocess="xml-stripblanks" alias="icons/scalable/apps/jp.pocka.plac.gtk-adwaita.svg">app-icon.svg</file>
• data/icons/scalable/actions/stop-large-symbolic.svg (new)
  • @@ -0,0 +1,6 @@
    + <?xml version="1.0" encoding="UTF-8"?> + <!-- + SPDX-FileCopyrightText: Gnome Developers + SPDX-License-Identifier: CC0-1.0 + --> + <svg xmlns="http://www.w3.org/2000/svg" height="16px" viewBox="0 0 16 16" width="16px"><path d="m 3.503906 2 h 9 c 0.828125 0 1.5 0.671875 1.5 1.5 v 9 c 0 0.828125 -0.671875 1.5 -1.5 1.5 h -9 c -0.832031 0 -1.5 -0.671875 -1.5 -1.5 v -9 c 0 -0.828125 0.667969 -1.5 1.5 -1.5 z m 0 0" fill="#222222"/></svg>
• data/jp.pocka.plac.gtk-adwaita.gschema.xml
  • @@ -53,6 +53,11 @@ SPDX-License-Identifier: Apache-2.0
    <summary>Show seek by 10secs buttons</summary> <description>Show buttons that seek forward/backwards by 10 seconds.</description> </key> + <key name="show-stop-button" type="b"> + <default>false</default> + <summary>Show stop button</summary> + <description>Show stop button next to play/pause button.</description> + </key> <key name="show-browse-item-separators" type="b"> <default>false</default> <summary>Show separators for browse items</summary>
• data/ui/playback-toolbar.ui
  • @@ -156,6 +156,17 @@ SPDX-License-Identifier: Apache-2.0
    <property name="action-name">pause_current_zone</property> </object> </child> + <child> + <object class="GtkButton" id="stop"> + <style> + <class name="flat" /> + </style> + <property name="label">Stop</property> + <property name="icon-name">stop-large-symbolic</property> + <property name="action-name">stop_current_zone</property> + <property name="sensitive">true</property> + </object> + </child> <child> <object class="GtkButton" id="seek_forward_10"> <style>
• src/Application.vala
  • @@ -111,11 +111,17 @@ namespace PlacGtkAdwaita {
    show_seek_by_10secs.title = "Show seek by 10secs buttons"; show_seek_by_10secs.subtitle = "Show buttons that seek forward/backwards by 10 seconds."; + var show_stop_button = new Adw.SwitchRow(); + settings.settings.bind(Settings.SHOW_STOP_BUTTON, show_stop_button, "active", DEFAULT); + show_stop_button.title = "Show stop button"; + show_stop_button.subtitle = "Show stop button next to play/pause button. Stopping playback releases audio device immediately."; + var appearance = new Adw.PreferencesGroup(); appearance.add(disable_csd); appearance.add(label_parsing_enabled); appearance.add(show_browse_item_separators); appearance.add(show_seek_by_10secs); + appearance.add(show_stop_button); appearance.title = "Appearance"; var focus_browse_items_on_load = new Adw.SwitchRow();
• src/Settings.vala
  • @@ -24,6 +24,7 @@ namespace PlacGtkAdwaita {
    public const string DISCOVERY_UDP_PORT = "discovery-udp-port"; public const string LABEL_PARSING_ENABLED = "label-parsing-enabled"; public const string SHOW_SEEK_BY_10SECS = "show-seek-by-10secs"; + public const string SHOW_STOP_BUTTON = "show-stop-button"; public const string SHOW_BROWSE_ITEM_SEPARATORS = "show-browse-item-separators"; public const string FOCUS_BROWSE_ITEMS_ON_LOAD = "focus-browse-items-on-load"; public const string DISABLE_CSD = "disable-csd";
• src/Widgets/PlaybackToolbar.vala
  • @@ -33,6 +33,9 @@ namespace PlacGtkAdwaita {
    [GtkChild] private unowned Gtk.Button pause; + [GtkChild] + private unowned Gtk.Button stop; + [GtkChild] private unowned Gtk.Button prev;
  • @@ -183,6 +186,26 @@ namespace PlacGtkAdwaita {
    }); }); + stop.clicked.connect(() => { + if (conn == null || selected_zone == null) { + return; + } + + this.disable_actions(); + this.control_async.begin(conn, selected_zone, STOP, (_obj, res) => { + try { + this.control_async.end(res); + } catch (GLib.Error error) { + GLib.log("Plac", LEVEL_CRITICAL, "Stop control failed: %s", error.message); + } + + this.enable_actions(); + + seek.set_value(0); + schedule_seek(0); + }); + }); + prev.clicked.connect(() => { if (conn == null || selected_zone == null) { return;
  • @@ -238,6 +261,7 @@ namespace PlacGtkAdwaita {
    settings.settings.bind(Settings.SHOW_SEEK_BY_10SECS, seek_backwards_10, "visible", GET); settings.settings.bind(Settings.SHOW_SEEK_BY_10SECS, seek_forward_10, "visible", GET); + settings.settings.bind(Settings.SHOW_STOP_BUTTON, stop, "visible", GET); this.render(); }